Skip to content
Smart Cities Group Project

Merge Requests Workflow

Before the merge request is approved/merged

Checklist

  • All tasks have been closed
  • The user story is in the verify column
  • Go through Acceptance Criteria and make sure the reviewer can check them off
  • Hyperlinks to relevant documentation on pages in the user story
  • Assign a reviewer based on the rotation schedule below

What does a reviewer do when reviewing a merge request?

Checklist

  • Go through the Acceptance Criteria and check them off
  • Go through the code changes and leave feadback as comments where necessary
  • Go through the Definition of Done and check them off
  • If everything is okay, approve the merge request
  • The requester can then merge the merge request

Review Template

1
2
3
4
5
6
7
**Acceptance Criteria**

All acceptance criteria have been met:

**Definition of Done**

All Definition of Done criteria have been met:

Who do you select to review the merge request

We rotate reviewers so that everyone gets a chance to review merge requests. Discuss with the team who should review your merge request. Rotation is per merge request.

Rotation schedule

Reviewer Amount of reviews
Sebas
Sam .
Anwar
Brian
Casper .